Use vector drawable for app icon #7197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmontwe
approved these changes
Sep 27, 2023
There was a problem hiding this comment.
Nice, I like the updated icon.
The only* difference between the debug and release icon are 3 color definitions:
#ff1744vs#5917ff#ff4569vs#7a45ff#d81a3dvs#531ad8
They could be replaced by a color resource definition to easily recolor them for the different app variants.
*Just noticed that some of the strokeWidth definitions marginally differ between both icons, rounding error?
android:strokeWidth="6"
vs
android:strokeWidth="5.99999952"
cketti
force-pushed
the
simplify_app_icon
branch
from
47d3f45 to
aa47ea2
Compare
Remove shadows (using blur) from the logo. This allows us to use a vector drawable as app icon.
cketti
force-pushed
the
simplify_app_icon
branch
from
aa47ea2 to
b44d180
Compare
|
I updated the vector drawable to use color references. Interestingly, the stroke width of most paths seems to be irrelevant. At some point we might want to clean up the source SVG to set those to 0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove shadows and semi-transparent layers on top of the app logo. This makes for a less complex image that can be an Android vector drawable.
Icons used in Compose UI modules haven't been updated. This will be done in a follow-up pull request.
Fixes #6801