Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't fail when exporting an identity without a sender name #6841

Merged
merged 1 commit into from
Apr 24, 2023
Merged

Don't fail when exporting an identity without a sender name #6841

merged 1 commit into from
Apr 24, 2023

Conversation

cketti
Copy link
Member

@cketti cketti commented Apr 21, 2023

To test this, create an identity where the "Your name" field is left empty, then export settings.

@cketti cketti requested a review from wmontwe April 21, 2023 16:27
wmontwe
wmontwe approved these changes Apr 24, 2023
View reviewed changes
Copy link
Member

@wmontwe wmontwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cketti cketti changed the base branch from 6.6-MAINT to main April 24, 2023 11:34
@cketti cketti force-pushed the fix_export_settings branch from 626fb62 to 9e7ee72 Compare April 24, 2023 11:36
@cketti cketti merged commit 975049e into main Apr 24, 2023
@cketti cketti deleted the fix_export_settings branch April 24, 2023 11:45
@cketti cketti mentioned this pull request Oct 1, 2023
Closed
2 tasks
@cketti cketti mentioned this pull request Oct 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmontwe wmontwe wmontwe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cketti @wmontwe