Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests #827

Merged
merged 22 commits into from
Aug 14, 2024
Merged

Tests #827

merged 22 commits into from
Aug 14, 2024

Conversation

ol0lll
Copy link
Member

@ol0lll ol0lll commented Aug 13, 2024

Make sure these boxes are checked before submitting your pull request - thank you!

  • All coding styles are fulfilled. (How to check for cs issues?)
  • All tests are running locally. (How to run the test?)
  • Necessary update hooks are provided.
  • User roles have correct access for new introduced permission.
  • Every thunder module has a README.md in its root. Follow this guidelines, but we don't need every topic.
  • Code is covered with well-balanced amount of inline comments.
  • New features or changes are documented.

If you are really awesome, then your feature is covered by additional tests. Well done!

This reverts commit 37e9ae6.
@ol0lll ol0lll added test-min Triggers the minimum requirements testing test-upgrade Triggers the upgrade path testing labels Aug 14, 2024
@ol0lll ol0lll temporarily deployed to thunder-pr-827 August 14, 2024 10:22 Inactive
@ol0lll ol0lll closed this Aug 14, 2024
@ol0lll ol0lll reopened this Aug 14, 2024
composer.json Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
@ol0lll ol0lll temporarily deployed to thunder-pr-827 August 14, 2024 11:29 Inactive
Copy link
Member

@dbosen dbosen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dbosen dbosen merged commit 8ee0c94 into 7.3.x Aug 14, 2024
7 checks passed
@dbosen dbosen deleted the test-the-tests branch August 14, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test-min Triggers the minimum requirements testing test-upgrade Triggers the upgrade path testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants