Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thunder 7.1.5 release #763

Merged
merged 3 commits into from
Dec 21, 2023
Merged

Thunder 7.1.5 release #763

merged 3 commits into from
Dec 21, 2023

Conversation

chrfritsch
Copy link
Member

Make sure these boxes are checked before submitting your pull request - thank you!

  • All coding styles are fulfilled. (How to check for cs issues?)
  • All tests are running locally. (How to run the test?)
  • Necessary update hooks are provided.
  • User roles have correct access for new introduced permission.
  • Every thunder module has a README.md in its root. Follow this guidelines, but we don't need every topic.
  • Code is covered with well-balanced amount of inline comments.
  • New features or changes are documented.

If you are really awesome, then your feature is covered by additional tests. Well done!

@chrfritsch chrfritsch added test-min Triggers the minimum requirements testing test-upgrade Triggers the upgrade path testing labels Dec 21, 2023
ol0lll
ol0lll previously approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@ol0lll ol0lll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@ol0lll ol0lll temporarily deployed to thunder-pr-763 December 21, 2023 13:42 Inactive
@chrfritsch chrfritsch merged commit a61cfd7 into 7.1.x Dec 21, 2023
7 checks passed
@chrfritsch chrfritsch deleted the release-715 branch December 21, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ol0lll ol0lll ol0lll left review comments

Assignees
No one assigned
Labels
test-min Triggers the minimum requirements testing test-upgrade Triggers the upgrade path testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrfritsch @ol0lll