Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the color of the centered comment FAB in dark mode #1691

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Feb 7, 2025

Pull Request Description

This PR adds a background color to the centered post page FAB in dark mode. I chose not to add this color in light mode because I think the FAB already stands out well against the comments due to the shadow.

I tested...

  • the old and new post pages
  • light and dark mode
  • combined and separated FAB

Issue Being Fixed

Issue Number: #1689

Screenshots / Recordings

qemu-system-x86_64_wspLkWkSp6.mp4

Checklist

  • If a new package was added, did you ensure it uses an appropriate license and is actively maintained?
  • Did you use localized strings (and added appropriate descriptions) where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I do personally prefer a more muted colour, but we can roll with this for now and get some additional feedback!

@hjiangsu hjiangsu merged commit c95b490 into thunder-app:develop Feb 18, 2025
1 check passed
@micahmo
Copy link
Member Author

micahmo commented Feb 18, 2025

Agreed!

@micahmo micahmo deleted the fix/comment-fab-dark branch February 18, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants