Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UX for toggling pure black theme #1690

Merged
merged 2 commits into from
Feb 18, 2025
Merged

Conversation

hjiangsu
Copy link
Member

@hjiangsu hjiangsu commented Feb 7, 2025

Pull Request Description

This PR applies the feedback from #1605 (comment) to improve the UX for enabling and disabling pure black theme. Here's the new flow:

  • Theme only contains light, dark and system options
  • When the theme is set to dark or system, an option to enable pure black theme will be shown
  • When the pure black theme is enabled, dark themes will use the pure black themes (applies to dark mode, and system dark mode)

I've also added some migration steps for those who are currently using the pure black theme directly! I've tested most if not all possible variations, and also tested the migration steps.

Note: I've kept setting_theme_system_pure_black and systemThemePureBlack the same to prevent issues with users who were previously using that setting. I have however, renamed the variables to match the new context.

Issue Being Fixed

Issue Number: #1598

Screenshots / Recordings

Checklist

  • If a new package was added, did you ensure it uses an appropriate license and is actively maintained?
  • Did you use localized strings (and added appropriate descriptions) where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@hjiangsu hjiangsu added this to the 0.7.0 milestone Feb 7, 2025
@micahmo
Copy link
Member

micahmo commented Feb 7, 2025

The code LGTM!

The only comment I have is about searching. When I search for "dark" I get a result called "System Dark Mode", but clicking that search result brings me to the new "Pure Black" toggle. I think we probably just need to change the resource string for that setting to "Pure Black".

qemu-system-x86_64_5VsK2nrJuY.mp4

@hjiangsu
Copy link
Member Author

I think we probably just need to change the resource string for that setting to "Pure Black".

Done!

@hjiangsu hjiangsu merged commit ef79c09 into develop Feb 18, 2025
1 check passed
@hjiangsu hjiangsu deleted the feat/pure-black-ux branch February 18, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants