Cheerio type fix #591
Merged
Cheerio type fix #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for taking time to contribute! 🎉
Before we move on, fill out the template so that we can better understand your contribution.
What is the purpose of this PR?
Is there a related issue?
cheeriojs/cheerio#3974
Please describe your changes.
The project used "@types/cheerio": "0.22.35", but it does not match cheerio's version used (1.0.0-rc). When removing "@types/cheerio", lots of typing errors occurs.
This PR fixed those typing errors, as well as removed the deprecated usage of cheerio's default export.
Are there any possible drawbacks or side-effects?
How to verify the changes?