Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Drop hub command from the RELEASE.md #585

Merged
merged 2 commits into from
Jun 13, 2023
Merged

docs: Drop hub command from the RELEASE.md #585

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce816ec
docs: Drop hub command from the RELEASE.md
r-hang Jun 9, 2023
957045b
Update RELEASE.md
sywhang Jun 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 15 additions & 14 deletions RELEASE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,6 @@
Release process
===============

Prerequisites
-------------

Make sure you have `hub` installed.

```
brew install hub
```

Releasing
---------

Expand Down Expand Up @@ -66,9 +57,11 @@ To release new versions of ThriftRW Go, follow these instructions.
git add version/version.go CHANGELOG.md
git commit -m "Preparing release v$VERSION"

8. Make a pull request with these changes against `master`.
8. Make a pull request with these changes against `master`. Push the recently
created release branch to origin and create a new pull request into `master`
in the Github UI.

hub pull-request -b master --push
git push origin HEAD:$(whoami)/release

9. Land the pull request after approval as a **merge commit**. To do this,
select **Create a merge commit** from the pull-down next to the merge
Expand All @@ -93,7 +86,13 @@ To release new versions of ThriftRW Go, follow these instructions.

11. Tag a release.

hub release create -o -m v$VERSION -t master v$VERSION
git tag -a v$VERSION -m v$VERSION
git push origin v$VERSION

Go to the "Release" section in the Github UI, and click "Draft a new release".
Select the tag you just pushed to origin. The release title should be the
tag name (e.g. v$VERSION) and the contents of the CHANGELOG.md for the
for the release version should be copied into the release description.

12. Copy the changelog entries for this release into the release description
in the newly opened browser window.
Expand Down Expand Up @@ -134,10 +133,12 @@ To release new versions of ThriftRW Go, follow these instructions.

make generate

18. Open a PR with your changes against `dev` to back to development.
18. Open a PR with your changes against `dev` to back to development. Push
the recently created `back-to-dev` branch to origin and create a pull
request into `dev` from the Github UI.

git commit -am "Back to development"
hub pull-request -b dev --push
git push origin back-to-dev

19. Merge this pull request once approved as a merge commit.

Expand Down