Back to dev #584
Merged
Back to dev #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This release contains the following changes: - AddTemplate template option. - thriftbreak: support for changed types, new files, and optional JSON output. - String() performance improvements for string type definitions.
PR (#554) introduced an optimization for the String() method of typedefs. There are two issues with this change: - Since the "fmt" import was global, if fmt.Sprint was dropped from the typedef code generation the import would be unused. - Using compiled.RootTypeSpec for isStringType results in situations where a non-string type is return from a String() function resulting in uncompilable code. func(v StringReDef) String() string { x := (stringdef.StringDef)(v) return x } This happens when a type is a typedef of another string typedef. I've added generated code cases to demonstrate and verify the corrected behavior.
This commit serves as the v1.30.0 release. The commit merged in (#567) was never tagged and released as v1.30.0 as a bug was found in that commit before we tagged a release for it. This commit contains the fix for the aforementioned bug. This release contains the following changes: - AddTemplate template option. - thriftbreak: support for changed types, new files, and optional JSON output. - String() performance improvements for string type definitions.
Codecov Report
@@ Coverage Diff @@
## dev #584 +/- ##
=======================================
Coverage 68.01% 68.01%
=======================================
Files 142 142
Lines 23878 23878
=======================================
Hits 16241 16241
Misses 4577 4577
Partials 3060 3060
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tchung1118
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.