Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update generated doc strings and make generate #580

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Conversation

r-hang
Copy link
Contributor

@r-hang r-hang commented Jun 7, 2023

Update generated doc strings and make generate

These changes are the result of:

  • Re-tabbing the doc string generation logic of gen/enum.go and gen/field.go
  • running 'GO111MODULE=on make generate' on dev.

These steps are performed to update generated code, make the generated
code compliant with gofmt, and resolve release issues ahead of time.

@r-hang r-hang requested a review from tchung1118 June 7, 2023 17:26
@tchung1118
Copy link
Collaborator

Seems like CI failed?

@r-hang r-hang force-pushed the rhang/run-generate branch from f5a7e9b to ce8a083 Compare June 7, 2023 21:44
@r-hang r-hang changed the title pre-release: Run make generate Update generated doc strings and make generate Jun 7, 2023
These changes are the result of:
- Re-tabbing the doc string generation logic of gen/enum.go and gen/field.go
- running 'GO111MODULE=on make generate' on dev.

These steps are performed to update generated code, make the generated
code compliant with gofmt, and resolve release issues ahead of time.
@r-hang r-hang force-pushed the rhang/run-generate branch from ce8a083 to 615c7c0 Compare June 7, 2023 21:51
@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Merging #580 (615c7c0) into dev (9197231) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #580   +/-   ##
=======================================
  Coverage   68.01%   68.01%           
=======================================
  Files         142      142           
  Lines       23878    23878           
=======================================
  Hits        16241    16241           
  Misses       4577     4577           
  Partials     3060     3060           
Impacted Files Coverage Δ
gen/enum.go 99.00% <ø> (ø)
gen/field.go 91.34% <ø> (ø)
gen/internal/tests/collision/collision.go 65.63% <ø> (ø)
gen/internal/tests/containers/containers.go 56.88% <ø> (ø)
...um-text-marshal-strict/enum-text-marshal-strict.go 77.31% <ø> (ø)
gen/internal/tests/enum_conflict/enum_conflict.go 72.34% <ø> (ø)
gen/internal/tests/enums/enums.go 83.40% <ø> (ø)
gen/internal/tests/exceptions/exceptions.go 60.35% <ø> (ø)
.../internal/tests/hyphenated-file/hyphenated-file.go 60.67% <ø> (ø)
.../internal/tests/hyphenated_file/hyphenated_file.go 60.67% <ø> (ø)
... and 9 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@r-hang r-hang merged commit 0977c0d into dev Jun 7, 2023
@r-hang r-hang deleted the rhang/run-generate branch June 7, 2023 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants