Addressing missed feedback from #551 and returning FilePath #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #553 +/- ##
=======================================
Coverage 67.99% 68.00%
=======================================
Files 139 139
Lines 23722 23729 +7
=======================================
+ Hits 16130 16137 +7
Misses 4537 4537
Partials 3055 3055
Continue to review full report at Codecov.
|
shirchen
changed the title
sywhang
reviewed
Dec 3, 2021
internal/compare/compare.go
Outdated
| file, err := filepath.Rel(p.GitDir, filePath) | ||
| if err != nil { | ||
| // If a file was deleted, then we will not be able to | ||
| // find a full path to it. |
There was a problem hiding this comment.
did you mean to say we will not be able to find a relative path to it?
abhinav
approved these changes
Dec 3, 2021
Co-authored-by: Sung Yoon Whang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing leftover comments and changing thriftbreak to return filepath relative to the passed in repository.