Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support fast Zap logging #361

Merged
merged 25 commits into from
Aug 6, 2018
Merged
Show file tree
Hide file tree
Changes from 19 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ go_import_path: go.uber.org/thriftrw

matrix:
include:
- go: 1.7
- go: 1.8
- go: 1.9
- go: '1.10'
env: LINT=1
Expand Down
4 changes: 3 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## [Unreleased]
- No changes yet.
- All structs and its underlying components, enums, and typedefs of non-primitives
now implement `zapcore.ObjectMarshaler` or `zapcore.ArrayMarshaler`, depending
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discrepancy between the description and the changelog with respect to typedef support.

on its underlying type. For typedefs of primitives, the logging is up to the user, simply by casting it down to the root type and using the respective Add/Append... method of the Zap encoder.

## [1.12.0] - 2018-06-25
### Added
Expand Down
133 changes: 133 additions & 0 deletions envelope/internal/tests/enums/types.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 19 additions & 0 deletions envelope/internal/tests/exceptions/types.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions envelope/internal/tests/services/cache_clear.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 11 additions & 0 deletions envelope/internal/tests/services/cache_clearafter.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 20 additions & 0 deletions envelope/internal/tests/services/conflictingnames_setvalue.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

28 changes: 28 additions & 0 deletions envelope/internal/tests/services/keyvalue_deletevalue.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading