Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple TACo images #684

Closed
wants to merge 4 commits into from
Closed

Conversation

derekpierre
Copy link
Member

@derekpierre derekpierre commented Dec 4, 2023

Short-term quick and dirty fixes for TACo application images.

In the medium/longer-term the original png images should be provided as SVG images so that they can more easily be edited.

Notes for reviewers:
I'm less familiar with this codebase, so if I missed anything let me know.

@derekpierre derekpierre changed the title [WIP] Simple TACo images Simple TACo images Dec 4, 2023
@derekpierre derekpierre marked this pull request as ready for review December 4, 2023 23:44
@derekpierre
Copy link
Member Author

@theref not sure what's up with CI - could you take a look?

@piotr-roslaniec
Copy link
Member

@derekpierre You need to update the yarn.lock lockfile with yarn install. I've tried doing it myself but I don't have write access to your branch.

@cygnusv
Copy link
Member

cygnusv commented Dec 5, 2023

@theref not sure what's up with CI - could you take a look?
@derekpierre You need to update the yarn.lock lockfile with yarn install. I've tried doing it myself but I don't have write access to your branch.

Apart from this, in this repo we need to create PRs from branches, not from forks, so CI works properly

@piotr-roslaniec
Copy link
Member

@cygnusv I think we need some permissions to push to the origin branches

ERROR: Permission to threshold-network/token-dashboard.git denied to piotr-roslaniec.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

@derekpierre
Copy link
Member Author

Closed in favour of #686

@derekpierre derekpierre closed this Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants