-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Minting success page #37
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments to look at before the merge
Removed `skipActiveWalletCheck` prop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some non-blocking comments but overall looking good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-blocking, but should be fixed (probably in a separate PR)
In the minting flow we have two different success steps
a) minting-completed"
- when the optimistic minting is finalized but the tbtc tokens are not send to the address yet
b) completed
- when the optimistic minting is finalized and the tbtc tokens are sent to the receiver
It looks like we distinguish that in the main page but we don`t show that in the timeline
Here, for complete
step, the last item in the timeline should be completed
but it is active
in both cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this line should be updated?
id: DepositDetailsStep.MintingCompleted,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, I think the issue is here:
const isComplete = itemIdIndex < currentStepIndex |
itemIdIndex
is never lower than currentStepIndex
when it comes to last timeline item.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ref: #5
This PR introduces minting success page
Please note: the summary list (above the button) will be included with separate PR when required changes will get merged regarding to #36