Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-up v2 #27

Merged
merged 27 commits into from
Jan 25, 2024
Merged

Clean-up v2 #27

merged 27 commits into from
Jan 25, 2024

Conversation

michalsmiarowski
Copy link
Contributor

@michalsmiarowski michalsmiarowski commented Jan 15, 2024

Work in progress...

Ref: #1

This continues the work from #12, #11, #10, #8 and #7. It removes all unnecessary things that was missed in those PRs.

TODO:

  • Clean-up useFetchTvl hook
  • Clean-up threshold-ts lib
  • Clean-up redux store
  • Check for any other unused components/types that we've missed
  • Remove unused libs from node_modules
  • Change all occurences of tbtcV2 to just tbtc (addressed in Change all occurences of tbtcv2 to tbtc #28)
  • Remove feature flags

Removes all things related to tokens other than tbtc-v2. This includes:
- cleaning of useFetchTvl hook
- removing transaction slice
- cleaning of token slice
- removing hooks related to nu, keep and t tokens
- removing some other unrelated things
@michalsmiarowski michalsmiarowski changed the title Remove all things related to tokens other thn tbtc Cleanup v2 Jan 15, 2024
@michalsmiarowski michalsmiarowski self-assigned this Jan 15, 2024
@michalsmiarowski michalsmiarowski changed the title Cleanup v2 Clean-up v2 Jan 15, 2024
@michalsmiarowski michalsmiarowski marked this pull request as ready for review January 16, 2024 14:59
As of now, we do not use Storybook in this repository.
Copy link
Contributor

@kpyszkowski kpyszkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One remark before it gets merged

src/components/Sidebar/index.tsx Outdated Show resolved Hide resolved
kpyszkowski and others added 2 commits January 16, 2024 18:23
`useMemo` hook is unnecessary now since creating `navItems` variable is not a
costly operation anyway.
These icons were not used anymore.
kpyszkowski
kpyszkowski previously approved these changes Jan 25, 2024
Copy link
Contributor

@kpyszkowski kpyszkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

kpyszkowski and others added 2 commits January 25, 2024 15:42
The `useContract` hook was removed in earlied commits.
kpyszkowski and others added 2 commits January 25, 2024 15:58
TBTCV2 occurences were renamed to just TBTC.
Copy link
Contributor

@kpyszkowski kpyszkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@kpyszkowski kpyszkowski merged commit 881851c into main Jan 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants