-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Dark Theme #763
[WIP] Dark Theme #763
Conversation
Thanks @joelfischerr! I looked over the changes and tried it, and it looks great so far. There are certainly things that can be improved (e.g. the way the theme is loaded), but that can wait until the detail work on the styles is finished. So for now, I think the approach is good and the next steps would be to ensure that the light theme stays the same as before and to finish the changes required in the dark theme. If there is something you need from me (e.g. an updated loading spinner GIF), let me know! |
This was for some reason not formatted correctly, it's fixed now
app.css is not used anymore, as it has been replaced by app-light.css and app-dark.css
3d88e64
to
e78bad4
Compare
Trying to get the light theme to look exactly like the original theme
e78bad4
to
424b7e9
Compare
2e1baa1
to
cf5f501
Compare
I have not quite finished replicating the original theme, but I think I'm making progress. There are some custom icons that are loaded as images. Changing the colors in those is quite easy but I'm not sure how to load them when the theme changes. What do you think would be the best way? |
Which icons are you talking about? |
I think all files starting with |
Should solve: Dark theme setting is not available #9
To manage expectations, this is the first time I have tried to contribute code to anything that is bigger than a few hundred lines. So things are probably a bit (very) rough.
If you can point me to the general direction of the changes needed, I'm eager to get it up to the standard of the rest of the code.
I have basically tried to do what @dbrgn outlined in #9 (comment).
Todo:
app-dark/light.scss
_dialogs.scss
ic_pin.svg
is not updated on theme change.