Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Dark Theme #763

Closed
wants to merge 33 commits into from
Closed

Conversation

joelfischerr
Copy link
Contributor

@joelfischerr joelfischerr commented Feb 28, 2019

Should solve: Dark theme setting is not available #9

To manage expectations, this is the first time I have tried to contribute code to anything that is bigger than a few hundred lines. So things are probably a bit (very) rough.
If you can point me to the general direction of the changes needed, I'm eager to get it up to the standard of the rest of the code.

I have basically tried to do what @dbrgn outlined in #9 (comment).

Todo:

  • Clean up the colors in app-dark/light.scss
  • Improve loading the css files ([WIP] Dark Theme #763 (comment))
  • Remove the remaining differences between the current theme and the new light theme
  • The placeholder in the send file/image dialog is not themed (all other placeholders are, I don't yet know what is wrong here)
  • Check lint disable in _dialogs.scss
  • Poll and image icons (shown in message preview in navigation) are not yet themed as they are image files (light and dark options are probably needed)
  • Loading indicator is not yet themed as it is a gif
  • Message quote colors are incorrect, I don't yet know where these colors are coming from.
  • The color of ic_pin.svg is not updated on theme change.

@joelfischerr joelfischerr changed the title Dark Theme [WIP] Dark Theme Feb 28, 2019
@lgrahl lgrahl requested a review from dbrgn March 7, 2019 12:24
@dbrgn
Copy link
Contributor

dbrgn commented Mar 11, 2019

Thanks @joelfischerr! I looked over the changes and tried it, and it looks great so far.

There are certainly things that can be improved (e.g. the way the theme is loaded), but that can wait until the detail work on the styles is finished.

So for now, I think the approach is good and the next steps would be to ensure that the light theme stays the same as before and to finish the changes required in the dark theme.

If there is something you need from me (e.g. an updated loading spinner GIF), let me know!

@joelfischerr joelfischerr force-pushed the dark-theme-pr branch 2 times, most recently from 3d88e64 to e78bad4 Compare April 28, 2019 15:01
Trying to get the light theme to look exactly like the original theme
@joelfischerr
Copy link
Contributor Author

I have not quite finished replicating the original theme, but I think I'm making progress.

There are some custom icons that are loaded as images. Changing the colors in those is quite easy but I'm not sure how to load them when the theme changes. What do you think would be the best way?

@dbrgn
Copy link
Contributor

dbrgn commented Apr 29, 2019

Which icons are you talking about?

@joelfischerr
Copy link
Contributor Author

I think all files starting with ic_ in public/img/ are loaded as images while the vector icons from Angular Material are inlined allowing them to be themed with CSS (material.angular.io/components/icon/overview#svg-icons).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants