Fix labels for button bar in contact or group details view. #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Give each button a distinguished label so they state what they do. Fixes #654.
|
Thanks for the pull request! Note, if you are already preparing a pull request, there's no need to create a separate issue for it. The reason why we generally ask contributors to create issues before opening pull requests is that larger features/changes can be discussed before the issue creator spends too much time implementing something we'd like to do differently. Accessibility fixes are always welcome! |
|
Thanks, will not create issues for these kinds of fixes in the future, but submit pull requests directly. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Give each button a distinguished label so they state what they do. Fixes #654.