Allow easily clearing search box

[samuelT2]

Fix related to "add X to clear search bar", issue #92

• Clear search bar with ESC or X (X only works in Chrome)
• Hide search bar when conversation or contact is clicked

[CLAassistant]

All committers have signed the CLA.

[samuelT2]

CLA is signed, not sure why it's still showing as not signed.

[samuelT2]

CLA shows as not signed because my e-mail address is not linked to my commit (now it is, but I cannot modify existing commits).

[dbrgn]

CLA shows as not signed because my e-mail address is not linked to my commit (now it is, but I cannot modify existing commits).

You can easily fix this:

git config user.email [email protected]
git commit --amend --reset-author
git push --force

[samuelT2]

Very cool, did solve it, thanks!

[dbrgn]

Thanks! Some notes below.

[samuelT2]

Requested changes are done, anything else needed from my side? Sorry that I ask, my very first pull request...

[dbrgn]

Thanks for applying the fixes!

Requested changes are done, anything else needed from my side? Sorry that I ask, my very first pull request...

No, you did everything right. We're currently juggling with different tasks and priorities (especially now that a lot new users joined), so it may take a few days until we can review a submission!

I tested your changes, they seem to work nicely in Chromium! I like that the search box disappears when clicking on a conversation, that makes sense. However, in Firefox the ESC key does not seem to trigger the keyUp event 🤔 Maybe you can test as well? It's possible that Firefox does not consider all key types for the keyUp event.

I also had another thought: Right now ESC clears the input field if it contains a search. Maybe it could also hide the search box if it's already empty? This way, a search could be aborted by pressing ESC twice.

[samuelT2]

Sure - no hurry!

I tested your changes, they seem to work nicely in Chromium! I like that the search box disappears when clicking on a conversation, that makes sense. However, in Firefox the ESC key does not seem to trigger the keyUp event 🤔 Maybe you can test as well? It's possible that Firefox does not consider all key types for the keyUp event.

With which Firefox version are you testing currently? That ESC event works fine me with, it clears the search field in Chrome and Firefox 84.0.2 (64-Bit).

I also had another thought: Right now ESC clears the input field if it contains a search. Maybe it could also hide the search box if it's already empty? This way, a search could be aborted by pressing ESC twice.

This one is nice, and not much of work. Will do it and push it again.

[dbrgn]

With which Firefox version are you testing currently? That ESC event works fine me with, it clears the search field in Chrome and Firefox 84.0.2 (64-Bit).

Hm, that's strange, I'm also on 84.0.2 and for me the KeyUp listener is never even called. I'll wait for your update, and will then test again to find out what the reason is.

[threema-danilo]

One last change request, then this is ready to merge.

[threema-danilo]

Thanks @samuelT2!

[threema-danilo]

Deployed to https://web-beta.threema.ch/, testing welcome. If no major bugs in that release are discovered in the next 2-3 days, a public release will be made.

[threema-danilo]

Unfortunately even small features can have undesired side effects...

It seems that when searching through a lot of conversations (I have over 230 conversations), after clicking on a conversation, the search clears almost instantly, but it sometimes takes multiple seconds until the conversation has opened.

This has a lot to do with the inefficient architecture of AngularJS, where every UI update can trigger a lot of processing code, which in turn may cause yet another UI update.

For now, we might need to disable the clearing/hiding of the search when clicking on a search result. (Note: Clearing with ESC or by clicking on the X mark would remain.)

[samuelT2]

Ouch, well - didn't test it with 230+ conversations :). Shall I revert that change or will you do it?

[threema-danilo]

See #1042