Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing the conversation requests further messages #870

Closed
lgrahl opened this issue Aug 5, 2019 · 5 comments · Fixed by #874
Closed

Changing the conversation requests further messages #870

lgrahl opened this issue Aug 5, 2019 · 5 comments · Fixed by #874
Assignees
@dbrgn
Labels
bug It's a bug! ui User interface related
Milestone
v2.2.0

Comments

@lgrahl
Copy link
Contributor

lgrahl commented Aug 5, 2019

Bug Description

When changing the conversation in the UI to another and then back again, further messages are being requested, as if one would scroll up to request further messages manually.

Steps to Reproduce (for bugs)

  1. Open a conversation (A).
  2. Switch to another (B).
  3. Switch back to conversation (A).
  4. Look at the log.
  • Threema Web version: 2.2.0-beta.4
@lgrahl lgrahl added the bug It's a bug! label Aug 5, 2019
@lgrahl lgrahl added this to the v2.2.0 milestone Aug 5, 2019
@lgrahl lgrahl added the ui User interface related label Aug 5, 2019
@dbrgn
Copy link
Contributor

dbrgn commented Aug 5, 2019

For the record: This behavior does not happen with https://web-beta.threema.ch/archive/2.2.0-beta.3/. Changing chats is much smoother there.

@lgrahl lgrahl self-assigned this Aug 6, 2019
@lgrahl
Copy link
Contributor Author

lgrahl commented Aug 6, 2019

Can't confirm that. But between beta 2 and 3 something changed regarding the load more messages behaviour. Beta 2 does not load more messages when switching conversations. Beta 3 does.

@lgrahl
Copy link
Contributor Author

lgrahl commented Aug 6, 2019 •
edited
Loading

Let's treat this issue and the lagging one separately.

I've reverted 898e716 locally and that fixes the loading of further messages. Looks like one of the dependencies is the issue. How do you want to proceed here, @dbrgn?

@lgrahl
Copy link
Contributor Author

lgrahl commented Aug 6, 2019

Regarding the lagging: I did a profile between beta.4 (with 898e716 reverted) and did not see any notable difference. Thus, cannot confirm.

@lgrahl lgrahl assigned dbrgn and unassigned lgrahl Aug 6, 2019
@dbrgn
Copy link
Contributor

dbrgn commented Aug 6, 2019

🤦‍♀️ history keeps repeating itself.

#723

Sorry about that. Unfortunately it's not possible to add comments to a JSON file (package.json), but I'll pin the version to an exact version number, then it should be obvious that there's a reason for that.

@dbrgn dbrgn mentioned this issue Aug 6, 2019
Merged
@dbrgn dbrgn closed this as completed in #874 Aug 6, 2019
dbrgn pushed a commit that referenced this issue Aug 6, 2019
@threema-danilo
Downgrade angularjs-scroll-glue (#874)
141d01e 
This was already done in 06f1d5c, but
I accidentally re-upgraded. Version 2.2.0 causes laggy UI behavior when
switching chats.

This time the exact version is pinned, then it should be obvious that
there's a reason for that. Unfortunately comments cannot be added to
JSON files...

Fixes #870
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dbrgn dbrgn

Labels
bug It's a bug! ui User interface related
Milestone
v2.2.0
Development

Successfully merging a pull request may close this issue.

Downgrade angularjs-scroll-glue threema-ch/threema-web
2 participants
@dbrgn @lgrahl