Emojione v3 #201
Merged
Emojione v3 #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
First blocker is fixed, now blocked by joypixels/emojione#484. |
|
Second blocker is fixed, now blocked by joypixels/emojione#494 |
|
Next up: joypixels/emojione#496 |
|
Oh, how buggy is their new lib? Blockers after blockers… |
- Add new PNGs - Add new spritemap + mapping css - Update emojione.min.js - Update emoji picker - Update license file - Add greedyMatch option to emojify filter Greedy matching will allow us to parse emoji without an emoji variant selector.
|
Ready to test! |
sillych
approved these changes
May 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress. Fixes #54 and #44.
This is currently blocked by joypixels/emojione#480.