-
Notifications
You must be signed in to change notification settings - Fork 533
unicodeToImage class does not match PNG filename #484
Comments
@dbrgn thanks for pointing this out! I see the issue here and I'll get it fixed soon. We made a number of changes to the sprite structure with 3.0, the naming pattern you show above is not quite accurate but the new class specification is intentional. One class specifies the category and size, e.g. On a related note, we'll also be adding the option to set the sprite size as either 32 or 64, which will be available soon. |
Yes, sorry, I renamed emojione and emojione-32 to e1 to make the spritemap CSS file smaller.
I generated the spritemap myself by tweaking the config files from the v2 version, but if you're officially supporting them with v3 (for the 32x32 version), then that's even better :) |
Any ETA on this? :) |
The patch for this should be released today. |
@dbrgn this is fixed in 3.0.2, released today. |
When using spritemaps:
The codepoint used in the class name is
2639-fe0f
, but the filename of the corresponding emoji PNG from the download archive is just2639.png
. When generating spritemaps based on the name, the two don't match.It would be good if the two would match. Otherwise they have to be mapped manually, which is probably not the intent of this library.
(PS: Did you change the class name prefix from
emojione-
to_
on purpose?)The text was updated successfully, but these errors were encountered: