Revert clearing of search when clicking on conversation / contact #1042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that when searching through a lot of conversations (I have over 230 conversations), after clicking on a conversation, the search clears almost instantly, but it sometimes takes multiple seconds until the conversation has opened. This has a lot to do with the inefficient architecture of AngularJS, where every UI update can trigger a lot of processing code, which in turn may cause yet another UI update. For now, we need to disable the clearing/hiding of the search when clicking on a search result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that when searching through a lot of conversations (I have over
230 conversations), after clicking on a conversation, the search clears
almost instantly, but it sometimes takes multiple seconds until the
conversation has opened.
This has a lot to do with the inefficient architecture of AngularJS,
where every UI update can trigger a lot of processing code, which in
turn may cause yet another UI update.
For now, we need to disable the clearing/hiding of the search when
clicking on a search result.
Refs #1026.