Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clojure 1 12 #1442

Merged
merged 3 commits into from
Nov 13, 2024
Merged

Clojure 1 12 #1442

merged 3 commits into from
Nov 13, 2024

Conversation

frenchy64
Copy link
Contributor

@frenchy64 frenchy64 commented Sep 9, 2024

§ QA

No QA is needed.

§ Release Notes

intern: upgrade to Clojure 1.12

§ Squashed Commits

@frenchy64
Copy link
Contributor Author

Two worrying test failures:

https://github.com/threatgrid/ctia/actions/runs/10778046839/job/29891561955#step:18:673

FAIL in ctia.entity.vulnerability-test/ (test-vulnerability-routes-access-control) (access_control.clj:124)
es-store Green Max Record Visibility set to `Group` delete-search should only match and delete visible entities
expected: (zero? player-2-entity-count-2)
  actual: (not (zero? 1))

https://github.com/threatgrid/ctia/actions/runs/10778046839/job/29888775065#step:18:738

FAIL in ctia.entity.casebook-test/ (test-casebook-routes-access-control) (access_control.clj:125)
es-store TLP Green delete-search should only match and delete visible entities
expected: (= (-> (set player-1-expected-entity-list) (set/difference player-2-expected-entity-list) count) player-1-entity-count-2)
  actual: (not (= 0 2))

@yogsototh
Copy link
Contributor

this build fails with:

 in ctia.entity.vulnerability-test/ (test-vulnerability-routes-access-control) (access_control.clj:124)
es-store Green Max Record Visibility set to `Group` delete-search should only match and delete visible entities
expected: (zero? player-2-entity-count-2)
  actual: (not (zero? 1))
   34s for ctia.entity.vulnerability-test/test-vulnerability-routes-access-control.
    0s for ctia.entity.vulnerability-test/test-build-configurations-query.
   10s for ctia.entity.vulnerability-test/search-by-cpe-match-strings-test.
   14s for ctia.entity.vulnerability-test/test-vulnerability-routes.
   10s for ctia.entity.vulnerability-test/cpe-match-strings-paging-test.
   10s for ctia.entity.vulnerability-test/test-vulnerability-metric-routes.
  • choice 1: we discovered a Clojure 1.12 bug
  • choice 2: ho no... another flaky test

;)

@frenchy64
Copy link
Contributor Author

They do look familiar as flaky tests. Clearly they fail intermittently as the last merge shows.

@frenchy64 frenchy64 merged commit 2e4e3bf into master Nov 13, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants