Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drawSigLine should only work if lineWidth>0 #10

Closed
jokeyrhyme opened this issue Jun 8, 2011 · 1 comment
Closed

drawSigLine should only work if lineWidth>0 #10

jokeyrhyme opened this issue Jun 8, 2011 · 1 comment

Comments

@jokeyrhyme
Copy link
Contributor

After every update, I change the drawSigLine function like so:

function drawSigLine() {
if (!settings.lineWidth) { return; }
...
}

That way, I can set the lineWidth to 0 (or false) and turn off the signature line. If you think other people would like to control the presence of the signature line in this way, then it might be a good idea to throw this in.

For my use case (disabled signature line) this is more efficient than picking a transparent colour (or colour that matches the background). It does end up in one more conditional check for everyone who does want the signature line though...

@thomasjbradley
Copy link
Contributor

That sounds good too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants