Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of all the eth_chainid calls #81

Merged
merged 1 commit into from
Sep 7, 2021
Merged

Get rid of all the eth_chainid calls #81

merged 1 commit into from
Sep 7, 2021

Conversation

mveytsman
Copy link
Contributor

See ethers-io/ethers.js#901 (comment) for context

This saves an extra call to infura on every interaction with the blockchain. I think it's safe to use the StaticJsonRpcProvider with Metamask because we do a hard-reload on network change, but I'd appreciate it if you read the linked issue and confirmed my understanding @shazow . The alternative would be to use the JsonRpcProvider if we detect a wallet?

@netlify
Copy link

netlify bot commented Sep 2, 2021

✔️ Deploy Preview for thousandetherhomepage ready!

🔨 Explore the source changes: e062cac

🔍 Inspect the deploy log: https://app.netlify.com/sites/thousandetherhomepage/deploys/613111960408830007019a85

😎 Browse the preview: https://deploy-preview-81--thousandetherhomepage.netlify.app

@shazow
Copy link
Contributor

shazow commented Sep 2, 2021

This is probably fine, we replace the provider with wallet connect anyway right?

Copy link
Contributor

@shazow shazow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure this is good.

@shazow shazow merged commit 0cd2274 into master Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants