This repository has been archived by the owner on Dec 5, 2019. It is now read-only.
Pacto Server: replace Goliath with Reel #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: I also changed the commands to use the |
1 similar comment
maxlinc
added a commit
that referenced
this pull request
Feb 17, 2015
Pacto Server: replace Goliath with Reel
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pacto server has been based on Goliath, which uses EventMachine. Goliath doesn't seem to be under active development, and I've had a lot of trouble with EventMachine ranging from installation issues to it being difficult to do proper exception handling and avoid deadlocks. In fact, Pacto's own tests had to avoid running Pacto Server under JRuby to avoid issues.
This PR switches the server over to Reel, which powered by Celluloid. The Reel-based server seems to be cleaner, faster, more stable on Windows and JRuby, and easier to safely use with applications containing other concurrent processes.