Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Story Component Format #182

Merged
merged 24 commits into from
Mar 8, 2023

Conversation

BReimerTI
Copy link
Contributor

No description provided.

@BReimerTI BReimerTI marked this pull request as ready for review February 24, 2023 16:19
Copy link
Contributor

@rjschill87 rjschill87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @BReimerTI ! Looks good for the most part. Running through it locally, looks like storybook is having issues with the "Story" tab for each component.

Seems to be a common enough issue though: storybookjs/storybook#20475

So may want to hide the storysource add on for now?

@BReimerTI
Copy link
Contributor Author

Thanks @BReimerTI ! Looks good for the most part. Running through it locally, looks like storybook is having issues with the "Story" tab for each component.

Seems to be a common enough issue though: storybookjs/storybook#20475

So may want to hide the storysource add on for now?

@rjschill87 Thanks for taking a look! Yes, I think that works until they resolve the issue. I can push those changes up.

@rjschill87
Copy link
Contributor

rjschill87 commented Feb 28, 2023

@BReimerTI Think you may have already been chatting w/ @ljiang-ti on these:

  1. Looks like the "Apollo Client" tab is having an issue parsing the query.
  2. There's a browser error when viewing:
manager-bundle.mjs:1 [Storybook] One of your manager-entries failed: http://localhost:6006/sb-addons/storybook-i18n-4/manager-bundle.mjs TypeError: L.default.register is not a function

It looks like these are caused by the storybook-react-i18next and storybook-addon-apollo-client add-ons. After checking the add-ons themselves: https://github.com/stevensacks/storybook-react-i18next and https://github.com/lifeiscontent/storybook-addon-apollo-client , they look like they haven't updates in a while, and no response to whether or not they'll update to storybook 7:

lifeiscontent/storybook-addon-apollo-client#89
stevensacks/storybook-react-i18next#16

Considering those factors, think in this case it may be better to just write/maintain it ourselves. Storybook i18next guide

Would check w/ Product first though -- if they don't feel those tabs/translations are helpful/necessary, we can just remove the respective add-ons and implement the ones they want to keep.

@BReimerTI BReimerTI force-pushed the CLM-7570-convert-storybook-to-storybook-3 branch from 82782d0 to ac71268 Compare March 1, 2023 19:20
@BReimerTI
Copy link
Contributor Author

BReimerTI commented Mar 1, 2023

@jackanticoti what are you thoughts ☝️

I will add that removing storybook-addon-apollo-client will break any of the stories that are using the Apollo Client within their parameters.

@BReimerTI
Copy link
Contributor Author

@jackanticoti what are you thoughts ☝️

I will add that removing storybook-addon-apollo-client will break any of the stories that are using the Apollo Client within their parameters.

@rjschill87 @jackanticoti I pushed up changes related to the storybook add-on errors.

@BReimerTI BReimerTI merged commit c2feac3 into staging Mar 8, 2023
@BReimerTI BReimerTI deleted the CLM-7570-convert-storybook-to-storybook-3 branch March 8, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants