-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Story Component Format #182
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @BReimerTI ! Looks good for the most part. Running through it locally, looks like storybook is having issues with the "Story" tab for each component.
Seems to be a common enough issue though: storybookjs/storybook#20475
So may want to hide the storysource
add on for now?
@rjschill87 Thanks for taking a look! Yes, I think that works until they resolve the issue. I can push those changes up. |
@BReimerTI Think you may have already been chatting w/ @ljiang-ti on these:
It looks like these are caused by the lifeiscontent/storybook-addon-apollo-client#89 Considering those factors, think in this case it may be better to just write/maintain it ourselves. Storybook i18next guide Would check w/ Product first though -- if they don't feel those tabs/translations are helpful/necessary, we can just remove the respective add-ons and implement the ones they want to keep. |
82782d0
to
ac71268
Compare
@jackanticoti what are you thoughts ☝️ I will add that removing |
@rjschill87 @jackanticoti I pushed up changes related to the storybook add-on errors. |
No description provided.