Set a bigger window for save_and_open_screenshot
#983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
gabebw
force-pushed
the
gbw-chromedriver-bigger-screenshots
branch
from
952bfd2 to
4d4b0de
Compare
1680x1050 is the size of a 15" retina Macbook Pro. Without this setting, `save_and_open_screenshot` captures perhaps 75% of the screen, which makes it much less useful for debugging. I'm sure some people have bigger screens, and could use an even larger window size, but this feels like a good default.
gabebw
force-pushed
the
gbw-chromedriver-bigger-screenshots
branch
from
4d4b0de to
598aa91
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1680x1050 is the size of a 15" retina Macbook Pro.
Without this setting,
save_and_open_screenshotcaptures perhaps 75% of the screen, which makes it much less useful for debugging.I'm sure some people have bigger screens, and could use an even larger window size, but this feels like a good default.