Matcher delegate_method supports 'private: true'

[pr0d1r2]

Allow to specify delegate_method using with_private - which is described in documentation:

class Account
  delegate :plan, to: :subscription, private: true
end

# RSpec
describe Account do
  it { should delegate_method(:plan).to(:subscription).with_private }
end

# Minitest
class PageTest < Minitest::Test
  should delegate_method(:plan).to(:subscription).with_private
end

[matsales28]

LGTM. Thanks for the contribution!

[pr0d1r2]

@matsales28 Sweet! It is a pure pleasure to work with code specified that well with RSpec 🙏

[pr0d1r2]

Found one edge-case that still needs coverage:

it { is_expected.to delegate_method(:videos).to(:current_user).with_prefix('user').with_private }

Generates error:

     NoMethodError:
       private method `user_videos' called for

[matsales28]

Found one edge-case that still needs coverage:

it { is_expected.to delegate_method(:videos).to(:current_user).with_prefix('user').with_private }

Generates error:

     NoMethodError:
       private method `user_videos' called for

Yeah, it should also be good to test it in conjunction with the as qualifier.

  it { is_expected.to delegate_method(:videos).to(:current_user).with_prefix('user').as(:new_videos) }

Please let me know if you intend to add the coverage, we can wait for it to merge this PR, otherwise, I can work on improving the coverage, we'll likely need to change the code itself a bit as well to match the error message better.

[pr0d1r2]

@matsales28 force-pushed two commits again. The first one specify all combinations. Waiting to see those error messages changes.

[matsales28]

@pr0d1r2 Thanks again for the contribution, I just merged it!