Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump rubocop to 1.59.0 #1600

Merged
merged 1 commit into from
Dec 26, 2023
Merged

chore: bump rubocop to 1.59.0 #1600

merged 1 commit into from
Dec 26, 2023

Conversation

vsppedro
Copy link
Collaborator

  • chore: bump rubocop to 1.59.0
  • style: fix rubocop offense

@vsppedro vsppedro marked this pull request as ready for review December 26, 2023 19:49
@vsppedro vsppedro requested a review from matsales28 as a code owner December 26, 2023 19:49
@vsppedro
Copy link
Collaborator Author

vsppedro commented Dec 26, 2023 •
edited
Loading

Ruby 3.3.0 just came out. I tried running it with shoulda-matchers and I got an error on the CI, as you can see in this link.

To sort this out properly, we need to update RuboCop.

What do you think?

matsales28
matsales28 approved these changes Dec 26, 2023
View reviewed changes
Copy link
Member

@matsales28 matsales28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it looks good to me! Only a minor question on the change of the platform in the Gemfile.

matsales28
matsales28 reviewed Dec 26, 2023
View reviewed changes
Gemfile.lock Outdated
warnings_logger (0.1.1)
yard (0.9.25)
zeus (0.15.14)
method_source (>= 0.6.7)

PLATFORMS
ruby
x86_64-linux
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was that change intended?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, nice catch!

@vsppedro vsppedro merged commit 814468c into main Dec 26, 2023
16 checks passed
@vsppedro vsppedro deleted the update-rubocop branch December 26, 2023 21:22
@matsales28 matsales28 mentioned this pull request Jan 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matsales28 matsales28 matsales28 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vsppedro @matsales28