This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
update to use new aws-sdk version 3 structure #2560
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AWS SDK now has separate gems for each resource this changes paperclip to only use what it needs.
houndci-bot
reviewed
Feb 26, 2018
| @@ -1,5 +1,5 @@ | |||
| require 'spec_helper' | |||
| require 'aws-sdk' | |||
| require 'aws-sdk-s3' | |||
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
| @@ -123,15 +123,11 @@ module Storage | |||
| module S3 | |||
| def self.extended base | |||
| begin | |||
| require 'aws-sdk' | |||
| require 'aws-sdk-s3' | |||
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
|
@jdguzman This is already done and released in version 6.0.0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AWS SDK now has separate gems for each resource this changes paperclip to only use what it needs.
This change only requires the use of the
aws-sdk-s3gem. I've updated the readme also.