This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
Fix JRuby binary operator warning #2352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Nov 29, 2016
| @@ -46,7 +46,7 @@ def flush_writes #:nodoc: | |||
| end | |||
| end | |||
| unless @options[:override_file_permissions] == false | |||
| resolved_chmod = (@options[:override_file_permissions] &~ 0111) || (0666 &~ File.umask) | |||
| resolved_chmod = (@options[:override_file_permissions] & ~0111) || (0666 & ~File.umask) | |||
There was a problem hiding this comment.
Use 0o for octal literals.
Line is too long. [99/80]
|
Thanks! Can you please rebase against latest master, to check if CI passes? Thanks! |
|
Here ya go. |
|
Excellent, thank you! |
|
I just realize that we are still using the gem from the git repo for this fix. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following warning shown by JRuby 9.1.6.0:
gems/paperclip-5.1.0/lib/paperclip/storage/filesystem.rb:49: warning: `&' after local variable or literal is interpreted as binary operator even though it seems like argument prefix