update news #2134
update news #2134
Conversation
| @@ -1,4 +1,4 @@ | |||
| Releasing paperclip | |||
| Releasing paperclip | |||
There was a problem hiding this comment.
There is new trailing white space here. Can you please remove it?
|
|
||
| 5.0.0.beta1: | ||
| * Removed support for AWS v1 | ||
| * Rails Versioning: Removed support for Rails 3.2 and 4.1 |
There was a problem hiding this comment.
- Rails Versioning: Removed support for Rails 3.2 and 4.1
I'd phrase this as "Remove support for end-of-life'd Rails 3.2 and 4.1".
|
There are at least these more changes to add to the NEWS: |
| @@ -1,3 +1,3 @@ | |||
| module Paperclip | |||
| VERSION = "4.3.1" unless defined? Paperclip::VERSION | |||
| VERSION = "5.0.0.beta1" unless defined? Paperclip::VERSION | |||
There was a problem hiding this comment.
Freeze mutable objects assigned to constants.
|
Some changes to make: I'd make it the present tense for consistency with the rest of the file. I'd move together all the removals: And, more items to add: Thanks so much! This is great work. |
| * Drop support for end-of-life'd Ruby 2 | ||
| * Remove tests for JRuby and Rubinius from Travis CI (they were failing) | ||
| * Remove support for end-of-life'd Rails 3.2 and 4.1 | ||
| * Remove support for AWS v1 |
There was a problem hiding this comment.
Nitpick: I think "Drop" will read better than "Remove".
|
Can you please squash your commits together? Let me know if you need help. |
|
Squashed for you, releasing 5.beta1 soon. Thanks for your help! |
|
Thanks! |
No description provided.