Fix sourcing of asdf.sh #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Installing asdf via Homebrew now says: ``` To use asdf, add the following line to your ~/.zshrc: . /opt/homebrew/opt/asdf/libexec/asdf.sh ``` Yes, the laptop script is doing: `. /opt/homebrew/opt/asdf/asdf.sh` This used to work, but in no longer does because of the change in Homebrew/homebrew-core#81664 This corrects the file location being source. This failure was showing in CI and UTM locally for me.
|
@purinkle Yes, while that change did allow the error code to be seen by CI, once the fix for the actual issue was made in this branch, and asdf was able to run, I saw that the asdf.sh wasn't actually running in the context of the laptop script, and therefore asdf was not initialized successfully for the rest of the script, and the installation of ruby and node would fail. I've updated the PR description to make that more clear. Thanks. |
eebs
added a commit
to eebs/dotfiles
that referenced
this pull request
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installing asdf via Homebrew now says:
Yes, the laptop script is doing:
. /opt/homebrew/opt/asdf/asdf.shThis used to work, but in no longer does because of the change in
Homebrew/homebrew-core#81664
This corrects the file location being source.
This failure was showing in CI and UTM locally for me.
This change also undoes the change I had made in #620. While that change did allow the error code to be seen by CI, once the fix for the actual issue was made in this branch, and asdf was able to run, I saw that the asdf.sh wasn't actually running in the context of the laptop script, and therefore asdf was not initialized successfully for the rest of the script, and the installation of ruby and node would fail.