Replace target group binding chart with manifest

Newer versions of the Kubernetes provider support creating instances of
CRDs using the kubernetes_manifest resource, which removes the need for
the inline Helm chart.

aws/platform/modules/load-balancer-controller/README.md

@@ -13,13 +13,15 @@ target group bound to the Istio ingress gateway service.
 | <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 0.14.8 |
 | <a name="requirement_aws"></a> [aws](#requirement\_aws) | ~> 4.0 |
 | <a name="requirement_helm"></a> [helm](#requirement\_helm) | ~> 2.4 |
+| <a name="requirement_kubernetes"></a> [kubernetes](#requirement\_kubernetes) | ~> 2.6 |
 
 ## Providers
 
 | Name | Version |
 |------|---------|
 | <a name="provider_aws"></a> [aws](#provider\_aws) | ~> 4.0 |
 | <a name="provider_helm"></a> [helm](#provider\_helm) | ~> 2.4 |
+| <a name="provider_kubernetes"></a> [kubernetes](#provider\_kubernetes) | ~> 2.6 |
 
 ## Modules
 
@@ -33,8 +35,8 @@ target group bound to the Istio ingress gateway service.
 |------|------|
 | [aws_iam_policy.this](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/iam_policy) | resource |
 | [aws_iam_role_policy_attachment.this](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/iam_role_policy_attachment) | resource |
-| [helm_release.ingress_config](https://registry.terraform.io/providers/hashicorp/helm/latest/docs/resources/release) | resource |
 | [helm_release.this](https://registry.terraform.io/providers/hashicorp/helm/latest/docs/resources/release) | resource |
+| [kubernetes_manifest.target_group_binding](https://registry.terraform.io/providers/hashicorp/kubernetes/latest/docs/resources/manifest) | resource |
 | [aws_lb_target_group.this](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/lb_target_group) | data source |
 
 ## Inputs

aws/platform/modules/load-balancer-controller/main.tf

@@ -12,14 +12,19 @@ resource "helm_release" "this" {
   depends_on = [aws_iam_role_policy_attachment.this]
 }
 
-resource "helm_release" "ingress_config" {
-  chart     = "${path.module}/target-group-binding"
-  name      = "target-group-binding"
-  namespace = var.k8s_namespace
+resource "kubernetes_manifest" "target_group_binding" {
+  manifest = {
+    apiVersion = "elbv2.k8s.aws/v1beta1"
+    kind       = "TargetGroupBinding"
 
-  values = [
-    yamlencode({
-      name = "istio-ingress"
+    metadata = {
+      name      = "target-group-binding"
+      namespace = var.k8s_namespace
+    }
+
+    spec = {
+      targetGroupARN = data.aws_lb_target_group.this.arn
+      targetType     = "ip"
 
       networking = {
         ingress = [
@@ -44,11 +49,10 @@ resource "helm_release" "ingress_config" {
         name = "flightdeck-ingressgateway"
         port = 443
       }
+    }
+  }
 
-      targetGroupARN = data.aws_lb_target_group.this.arn
-    })
-  ]
-
+  # Wait for the CRD to be defined before creating
   depends_on = [helm_release.this]
 }
 

aws/platform/modules/load-balancer-controller/versions.tf

@@ -9,5 +9,9 @@ terraform {
       source  = "hashicorp/helm"
       version = "~> 2.4"
     }
+    kubernetes = {
+      source  = "hashicorp/kubernetes"
+      version = "~> 2.6"
+    }
   }
 }