Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rubocop offenses in generated files #353

Conversation

nicoalonsop
Copy link

When scaffolding a new model the generator generates the factory with rubocop offenses (using default rubocop configuration for rails).

Fixed offenses:

  • Style/StringLiterals
  • Style/FrozenStringLiteralComment

@nicoalonsop nicoalonsop force-pushed the fix-rubocop-offenses-in-generated-files branch from e5e5919 to bde6c23 Compare October 22, 2019 00:32
@nicoalonsop nicoalonsop force-pushed the fix-rubocop-offenses-in-generated-files branch from bde6c23 to be9e202 Compare October 22, 2019 00:39
@composerinteralia
Copy link
Collaborator

Thanks for the PR! thoughtbot uses https://github.com/thoughtbot/guides/blob/master/style/ruby/.rubocop.yml as the default config (it prefers double quotes and disables the frozen string literal comments), so I am going to close this.

You can read more about our choice of single quotes, and our choice of disabling the frozen string literal comment in the guides repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants