-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bundler before bundle install in travis ci builds #846
Update bundler before bundle install in travis ci builds #846
Conversation
Thanks for your work, @RochesterinNYC! This is a weird fix. Do you know if Travis will fix it soon-ish? If not, I'll merge. Thanks! |
@tute According to that linked issue in travis-ci, it seems they're wary of upgrading bundler to 1.10.x and don't seem to be in a rush to upgrade it anytime soon. They're suggesting this gem install bundler fix in the meantime. Hopefully, they'd update it soon honestly, but doesn't seem like they will? |
Merged into master. Thank you! 👏 😃 |
Thanks! |
Travis is currently using an old version of bunlder (1.8.x) that has a bug that's failing some of our builds. This fix was found from [1], and [2] is also relevant [1] thoughtbot/factory_bot#846 [2] travis-ci/travis-ci#3531
The TravisCI version of bundler is out of date, which can cause some problems install dependencies. Updating bundler as part of the install setup is the fix recommended by Travis (See travis-ci/travis-ci#3531) I was seeing it another govuk_template branch: - Travis bundler versions are quite out of date and can cause install errors There is an identical fix for govspeak: - alphagov/govspeak@1135ada More info: - rubygems/rubygems#1419 - thoughtbot/factory_bot#846
The TravisCI version of bundler is out of date, which can cause some problems install dependencies. Updating bundler as part of the install setup is the fix recommended by Travis (See travis-ci/travis-ci#3531) I was seeing it another govuk_template branch: - https://travis-ci.org/alphagov/govuk_template/builds/102056609 There is an identical fix for govspeak: - alphagov/govspeak@1135ada More info: - rubygems/rubygems#1419 - thoughtbot/factory_bot#846
* See the following on GitHub: * rubygems/bundler#3558 * thoughtbot/factory_bot#846
* See the following on GitHub: * rubygems/bundler#3558 * thoughtbot/factory_bot#846
for googling people, just do:
important part is that |
Hopefully this will fix the issue with ruby 1.9.3 and travis tests thoughtbot/factory_bot#846 Signed-off-by: Jordan Conway <[email protected]>
* Update #{self.prefix} to match yamllint rules yamllint defaults to require-starting-space, this change will fix the preamble to match the yamllint rules so that inline linting doesn't throw errors while eyaml editing files. Signed-off-by: Jordan Conway <[email protected]> * Update bundler before travis builds Hopefully this will fix the issue with ruby 1.9.3 and travis tests thoughtbot/factory_bot#846 Signed-off-by: Jordan Conway <[email protected]>
Travis CI Builds for
factory_girl
are broken because thebundler
version that Travis CI automatically uses at this time (1.7.6
) is coming across the following error/issue rubygems/bundler#3558 that was fixed in a later version/release.Having an outdated version of
bundler
in the Travis CI builds is an ongoing issue and this is currently the easiest work-around as seen in discussions at travis-ci/travis-ci#3531