Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bundler before bundle install in travis ci builds #846

Closed
wants to merge 1 commit into from
Closed

Update bundler before bundle install in travis ci builds #846

wants to merge 1 commit into from

Conversation

RochesterinNYC
Copy link
Contributor

Travis CI Builds for factory_girl are broken because the bundler version that Travis CI automatically uses at this time (1.7.6) is coming across the following error/issue rubygems/bundler#3558 that was fixed in a later version/release.

Having an outdated version of bundler in the Travis CI builds is an ongoing issue and this is currently the easiest work-around as seen in discussions at travis-ci/travis-ci#3531

@RochesterinNYC
Copy link
Contributor Author

@tute any thoughts on this? Should enable #838, #839, and #843 to be rebased and potentially merged.

@tute
Copy link

tute commented Dec 11, 2015

Thanks for your work, @RochesterinNYC! This is a weird fix. Do you know if Travis will fix it soon-ish? If not, I'll merge. Thanks!

@RochesterinNYC
Copy link
Contributor Author

@tute According to that linked issue in travis-ci, it seems they're wary of upgrading bundler to 1.10.x and don't seem to be in a rush to upgrade it anytime soon. They're suggesting this gem install bundler fix in the meantime. Hopefully, they'd update it soon honestly, but doesn't seem like they will?

@tute tute closed this in 3c0547f Dec 14, 2015
@tute
Copy link

tute commented Dec 14, 2015

Merged into master. Thank you! 👏 😃

@RochesterinNYC
Copy link
Contributor Author

Thanks!

yob added a commit to yob/pdf-reader that referenced this pull request Dec 15, 2015
Travis is currently using an old version of bunlder (1.8.x) that has a
bug that's failing some of our builds.

This fix was found from [1], and [2] is also relevant

[1] thoughtbot/factory_bot#846
[2] travis-ci/travis-ci#3531
dsingleton pushed a commit to alphagov/govuk_template that referenced this pull request Jan 13, 2016
The TravisCI version of bundler is out of date, which can cause some problems
install dependencies. Updating bundler as part of the install setup is the
fix recommended by Travis (See travis-ci/travis-ci#3531)

I was seeing it another govuk_template branch:
 - Travis bundler versions are quite out of date and can cause install errors

There is an identical fix for govspeak:
 - alphagov/govspeak@1135ada

More info:
- rubygems/rubygems#1419
- thoughtbot/factory_bot#846
dsingleton pushed a commit to alphagov/govuk_template that referenced this pull request Jan 13, 2016
The TravisCI version of bundler is out of date, which can cause some problems
install dependencies. Updating bundler as part of the install setup is the
fix recommended by Travis (See travis-ci/travis-ci#3531)

I was seeing it another govuk_template branch:
- https://travis-ci.org/alphagov/govuk_template/builds/102056609

There is an identical fix for govspeak:
- alphagov/govspeak@1135ada

More info:
- rubygems/rubygems#1419
- thoughtbot/factory_bot#846
i2000s added a commit to i2000s/i2000s.github.io that referenced this pull request Feb 14, 2016
cbrinker added a commit to cbrinker/hiera-puppet-helper that referenced this pull request Mar 24, 2016
thewoolleyman added a commit to rdy/fixture_builder that referenced this pull request Apr 4, 2016
thewoolleyman added a commit to rdy/fixture_builder that referenced this pull request Apr 4, 2016
joeyates added a commit to joeyates/imap-backup that referenced this pull request Apr 18, 2016
joeyates added a commit to joeyates/prismatic that referenced this pull request Apr 18, 2016
i2000s added a commit to i2000s/i2000s.github.io that referenced this pull request Jul 25, 2016
@equivalent
Copy link

for googling people, just do:

.travis.yml

language: ruby
before_install: gem install bundler
rvm:
  - 2.1.0
  - 2.1.1
  - 2.1.2
  - 2.1.3
  - 2.1.4
  - 2.1.5
  - 2.2.0
  - 2.3.0
  - ruby-head

important part is that before_install: gem install bundler it will install current bundler source

jordanconway added a commit to jordanconway/hiera-eyaml that referenced this pull request Nov 2, 2017
Hopefully this will fix the issue with ruby 1.9.3 and travis tests
thoughtbot/factory_bot#846

Signed-off-by: Jordan Conway <[email protected]>
rnelson0 pushed a commit to voxpupuli/hiera-eyaml that referenced this pull request Nov 8, 2017
* Update #{self.prefix} to match yamllint rules

yamllint defaults to require-starting-space, this change will fix the
preamble to match the yamllint rules so that inline linting doesn't
throw errors while eyaml editing files.

Signed-off-by: Jordan Conway <[email protected]>

* Update bundler before travis builds

Hopefully this will fix the issue with ruby 1.9.3 and travis tests
thoughtbot/factory_bot#846

Signed-off-by: Jordan Conway <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants