Fix #216, extra newline with customize_gemfiles #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe-sharp
force-pushed
the
main
branch
4 times, most recently
from
21f21b7 to
1495c7b
Compare
Merged
|
@nickcharlton this is ready for review but we may want to just proceed with #223 since it has this commit and adds a spec. Happy to proceed however works best for you. |
When using `customize_gemfiles`, two new line characters end up being inserted after the block comment, but it should only be one. This trims out the output to remove it. Fixes thoughtbot#216.
|
Thanks! I think this is worth merging in first to keep them separate, we can bring in the spec in #223. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On line 67 we join with two newlines, which will create an extra newline with how we recommend people use the Gemfile customization feature. This PR chomps the final newline to prevent that extra empty line described in issue #216