-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#170) Add ability to remove gem from appraisal #171
(#170) Add ability to remove gem from appraisal #171
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This looks good.
I think it would be useful to document this addition, do you think you could add it to the README? I'm thinking that perhaps the best approach here would be to add a new section for additional options like this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! This is definitely something I would have used before if it existed.
spec/acceptance/appraisals_file_bundler_dsl_compatibility_spec.rb
Outdated
Show resolved
Hide resolved
@composerinteralia I've gone ahead and made the suggested edits to the new contract and updated the PR to reflect those changes. @nickcharlton I've gone ahead and updated the |
Co-authored-by: Nick Charlton <[email protected]>
@composerinteralia would you have some time to re-review this in the coming days? I’m looking forward to getting this feature out so that we can use it at my company. If there’s anything that I can do to help with the release management of the gem as well, just let me know and I’d be happy to help. |
Hi @jebentier! Sorry, that's on me. I was meaning to go ahead and merge this but it turned into a fairly busy week. I'm going to merge this now and I'll take a look at doing a new release some time before this Friday. Thanks for your contribution! |
@nickcharlton no worries at all, it’s been rather busy here as well. Thank you for accepting this contribution. |
@nickcharlton any update on getting this released? |
@nickcharlton Any update on the release that will include this PR? It seems especially important since |
@nickcharlton Any update on the release that will include this PR? |
Thanks for your patience everyone — I just did this now and so you should see version 2.4.0 available now. |
Purpose of PR
This is adding the ability to use the
remove_gem
declaration within anappraise
block. By doing so the gem will be dropped from the generated Gemfile. This is useful in cases where an appraisal require the removal of old dependencies that are still used by the mainline source.Example Usage
Gemfile
Appraisals
To produce:
gemfiles/rails_5.gemfile
Fixes #170