Use manifest for precompiling assets with Sprockets 4 #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could this be released? |
|
Hi @sorich87! I'd love to get this merged. Could you rebase on |
|
@nickcharlton I enabled contributor pushes. Thanks! |
|
Closing as #814 was merged. |
|
@BenMorganIO @nickcharlton #814 doesn't actually fix the issue as a manifest file is required by sprockets-rails rails/sprockets-rails#369. Or maybe I'm missing something? |
|
Ooh, interesting. So, reading that issue it looks like we need a This comment suggests a (backwards compatible) possible solution, though: rails/sprockets-rails#369 (comment) What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Administrate doesn't currently work with Sprockets 4 because regexes in precompile list are deprecated. This pull request fixes the issues by using a manifest.js.