Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the subrepo targets output into plz-out/gen based on their pkg dir #3063

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Tatskaari
Copy link
Member

@Tatskaari Tatskaari commented Jan 30, 2024

This was a bit weird. We have the package root set, but it had no bearing on where we stash this guy in plz-out. Before and after:

➜  please git:(subrepo-target-out-dir) ✗ plz build ///third_party/go/github.com_stretchr_testify//assert 
Build finished; total time 480ms, incrementality 80.0%. Outputs:
///third_party/go/github.com_stretchr_testify//assert:assert:
  plz-out/gen/third_party/go/github.com_stretchr_testify/assert/assert.a

➜  please git:(subrepo-target-out-dir) ✗ plz plz build ///third_party/go/github.com_stretchr_testify//assert
Build finished; total time 670ms, incrementality 44.2%. Outputs:
///third_party/go/github.com_stretchr_testify//assert:assert:
  plz-out/gen/pkg/linux_amd64/github.com/stretchr/testify/assert/assert.a

This has no real functional effect, but seems like it might be the right thing to do.

@peterebden
Copy link
Member

Can you please check whether this has some impact on what the Go package driver should be doing with these paths? Feels like it might break it again (although I agree it's probably more sensible this way)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants