Revise saving API #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regarding to gif saving enhancement at thorvg/thorvg@a85470b, this patch aligns with changed interface. JavaScript interface changed: *Outdated - public save(target: ExportableType) - enum ExportableType *Introduced - public save2png(): void - public async save2gif(src: string): Promise<void>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hermet
reviewed
Nov 21, 2024
| * @since 1.0 | ||
| */ | ||
| public save(target: ExportableType): void { |
There was a problem hiding this comment.
Please check this, I think we can retain this common API for future extension.
save(src: string, export: string) {
if (export == "png") save2png()
else if (export == "gif") save2gif()
else //not support
}
Does it need to be async ?? |
@hermet Yes, file uploading and reading require async call |
hermet
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding to gif saving enhancement at thorvg/thorvg@a85470b, this patch aligns with changed interface.
JavaScript interface changed:
*Outdated
*Introduced