Respect file scheme URIs for SQLite. #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fraggerfox
force-pushed
the
respect-file-uri-for-sqlite
branch
from
043f221 to
9f794d8
Compare
fraggerfox
force-pushed
the
respect-file-uri-for-sqlite
branch
from
9f794d8 to
135bdf4
Compare
|
Thanks for your PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to introduce proper
file:Scheme URI parsing for SQLite DB option.The changes are done based on the following documentation
The current behavior where if no scheme (
file:) is mentioned, i.e. the file name is directly given like (opengist.db) the file is created under theopengist-homefolder. This way the existing behavior is maintained without breaking backward compatibility.With the new changes, the SQLite DB can be hosted independent of the home folder of Opengist. This also matches the behavior for PostgreSQL and MySQL / MariaDB, where the DB is not necessarily hosted within the Opengist home directory.
The
config.ymlfile has been updated to reflect these changes.