feat(web): prevent password manager autofill on filename inputs #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice idea, but is there an attribute common to all password managers ? Some standard or whatever ? |
|
Thanks for the reply! I believe these are the common ones after some research. We've seen little effect of the autocomplete=off for 1Password in our own projects. 1Password LastPass Bitwarden General use |
- Add autocomplete="off" to prevent browser autofill - Add data-lpignore for LastPass compatibility - Add data-bwignore for Bitwarden compatibility
s0up4200
changed the title
|
Added the rest now. These are the most common ones, and believe most other managers respect the autocomplete="off" attribute. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The filename input fields do not contain sensitive information and should not be managed by password managers or browser autofill. This PR adds multiple attributes to prevent unwanted autofill behavior:
data-1p-ignore: Prevents 1Password autofilldata-lpignore: Prevents LastPass autofilldata-bwignore: Prevents Bitwarden autofillautocomplete="off": Prevents browser native autofillThese changes improve the user experience by ensuring filename inputs remain clean and unaffected by password management tools.
https://developer.1password.com/docs/web/compatible-website-design/
https://community.bitwarden.com/t/where-is-the-developer-information/31547/3
https://stackoverflow.com/questions/20954944/stop-lastpass-filling-out-a-form
The bug:
The fix:
