Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Greatly simplify the driver #1

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Greatly simplify the driver #1

merged 1 commit into from
Jun 20, 2023

Conversation

jyn514
Copy link
Contributor

@jyn514 jyn514 commented Jun 20, 2023

  • Remove sysroot handling. Since improve filesearch::get_or_default_sysroot rust-lang/rust#103660 this is detected automatically!
  • Update to a newer toolchain; in particular install_ice_hook has changed its signature.
  • Remove the wrapper code; it only matters for cargo plugins, but ubrustc only has an equivalent of clippy-driver, not cargo-clippy.

you don't actually have to use this i just wanted to test it worked with a real driver for my blog post

- Remove sysroot handling. Since rust-lang/rust#103660 this is detected automatically!
- Update to a newer toolchain; in particular `install_ice_hook` has changed its signature.
- Remove the wrapper code; it only matters for cargo plugins, but ubrustc only has an equivalent of clippy-driver, not cargo-clippy.
@jyn514
Copy link
Contributor Author

jyn514 commented Jun 20, 2023

also i might write cargo-ubrustc soon (the thing that makes cargo ubrustc work out of the box) for the same reason

@thomcc
Copy link
Owner

thomcc commented Jun 20, 2023

you don't actually have to use this i just wanted to test it worked with a real driver for my blog post

i mean i dont see why i wouldn't take it.

@thomcc thomcc merged commit 4f6ed6e into thomcc:main Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants