Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add try/except on torch.hub for backwards compatibility #1

Closed

Conversation

rodrigoberriel
Copy link

Are you planning to finish facebookresearch#673? :)
Every new install I have to apply your patch 😄
This PR is about what has been requested to finally merge this.

@fmassa
Copy link

fmassa commented Apr 20, 2019

Oh, I've just merged facebookresearch#698 , I haven't seen that this PR was sent as well.

I like this PR as well because it uses except ImportError, can you rebase it on top of current master so that I can merge it? (basically add ImportError in the except)


EDIT: disregard this message, I thought this was a PR to maskrcnn-benchmark :-)

@rodrigoberriel
Copy link
Author

@fmassa don't worry, I tried to avoid taking over his PR =] the important is that now we don't need to patch every new install 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants