remove unused code

thomasneirynck · Apr 23, 2019 · c71806f · c71806f
1 parent dcdb81f
commit c71806f
Show file tree

Hide file tree

Showing 8 changed files with 7 additions and 38 deletions.
diff --git a/x-pack/plugins/maps/public/shared/components/layer_toc_actions.js b/x-pack/plugins/maps/public/shared/components/layer_toc_actions.js
@@ -29,23 +29,21 @@ export class LayerTocActions extends Component {
   state = {
     isPopoverOpen: false,
     supportsFitToBounds: false,
-    supportsDrawFilter: false
   };
 
   componentDidMount() {
     this._isMounted = true;
-    this._loadSupportedActions();
+    this._loadSupportsFitToBounds();
   }
 
   componentWillUnmount() {
     this._isMounted = false;
   }
 
-  async _loadSupportedActions() {
+  async _loadSupportsFitToBounds() {
     const supportsFitToBounds = await this.props.layer.supportsFitToBounds();
-    const supportsDrawFilter = this.props.layer.supportsDrawFilter();
     if (this._isMounted) {
-      this.setState({ supportsFitToBounds, supportsDrawFilter });
+      this.setState({ supportsFitToBounds });
     }
   }
 
@@ -121,7 +119,9 @@ export class LayerTocActions extends Component {
     }
     return smallLegendIcon;
   }
-  _getItems() {
+
+  _getPanels() {
+
     const visibilityToggle = this._getVisbilityIcon();
     const actionItems = [
       {
@@ -202,7 +202,7 @@ export class LayerTocActions extends Component {
       >
         <EuiContextMenu
           initialPanelId={0}
-          panels={this._getItems()}
+          panels={this._getPanels()}
           data-test-subj={`layerTocActionsPanel${cleanDisplayName(this.props.displayName)}`}
         />
       </EuiPopover>);

diff --git a/x-pack/plugins/maps/public/shared/layers/heatmap_layer.js b/x-pack/plugins/maps/public/shared/layers/heatmap_layer.js
@@ -54,10 +54,6 @@ export class HeatmapLayer extends AbstractLayer {
     return [this._getMbLayerId()];
   }
 
-  supportsDrawFilter() {
-    return true;
-  }
-
   syncLayerWithMB(mbMap) {
 
     const mbSource = mbMap.getSource(this.getId());

diff --git a/x-pack/plugins/maps/public/shared/layers/layer.js b/x-pack/plugins/maps/public/shared/layers/layer.js
@@ -80,10 +80,6 @@ export class AbstractLayer {
     return await this._source.supportsFitToBounds();
   }
 
-  supportsDrawFilter() {
-    return false;
-  }
-
   async getDisplayName() {
     if (this._descriptor.label) {
       return this._descriptor.label;

diff --git a/x-pack/plugins/maps/public/shared/layers/sources/es_geo_grid_source/es_geo_grid_source.js b/x-pack/plugins/maps/public/shared/layers/sources/es_geo_grid_source/es_geo_grid_source.js
@@ -97,10 +97,6 @@ export class ESGeoGridSource extends AbstractESSource {
     );
   }
 
-  supportsDrawFilter() {
-    return true;
-  }
-
   async getImmutableProperties() {
     let indexPatternTitle = this._descriptor.indexPatternId;
     try {

diff --git a/x-pack/plugins/maps/public/shared/layers/sources/es_search_source/es_search_source.js b/x-pack/plugins/maps/public/shared/layers/sources/es_search_source/es_search_source.js
@@ -45,10 +45,6 @@ export class ESSearchSource extends AbstractESSource {
     };
     return (<CreateSourceEditor onSelect={onSelect}/>);
   }
-  supportsDrawFilter() {
-    //todo. not quite right. only if source is geo_point
-    return true;
-  }
 
   constructor(descriptor, inspectorAdapters) {
     super({

diff --git a/x-pack/plugins/maps/public/shared/layers/sources/vector_source.js b/x-pack/plugins/maps/public/shared/layers/sources/vector_source.js
@@ -66,10 +66,6 @@ export class AbstractVectorSource extends AbstractSource {
     });
   }
 
-  supportsDrawFilter() {
-    return false;
-  }
-
   isFilterByMapBounds() {
     return false;
   }

diff --git a/x-pack/plugins/maps/public/shared/layers/tile_layer.js b/x-pack/plugins/maps/public/shared/layers/tile_layer.js
@@ -57,10 +57,6 @@ export class TileLayer extends AbstractLayer {
     return [this._getMbLayerId()];
   }
 
-  supportsDrawFilter() {
-    return false;
-  }
-
   syncLayerWithMB(mbMap) {
 
     const source = mbMap.getSource(this.getId());

diff --git a/x-pack/plugins/maps/public/shared/layers/vector_layer.js b/x-pack/plugins/maps/public/shared/layers/vector_layer.js
@@ -81,13 +81,6 @@ export class VectorLayer extends AbstractLayer {
     return [VectorStyle];
   }
 
-  supportsDrawFilter() {
-    //todo:
-    //this is wrong. _source should take into a account weather the source is geo_shape or geo_point. spatial filters are not supported by geo_shape backed index-patterns.
-    return this._source.supportsDrawFilter();
-  }
-
-
   /**
    * this should only be called if the source supports shape filter creation.
    * @return {*|Promise<void>}