Investigate flaky add new visualization test (elastic#15506)

* try to repro * try 30 times * some clean up and extra tests Don’t see how this should help, but switch to using data-test-subj and add a wait until loading line. Still, I don’t see that it would actually help. Also it took 50 test run to hit it once, so doubling the amount of times the test suite runs to improve chances of hitting it. * Throw the function in a retry Unfortunately it’s probably not worth investigating why the click sometimes fails, given how rare it is and that it’s only reproducible in the test environment. * Remove extra test loops * remove skip and check multiple times again * Fix issue with flaky field toggle selection * forgot await * More stabilizations * Stabilize by disabling toast auto hides on all dashboard tests * avoid all the retries to see if disabling toast auto hides was what was messing everything up * remove comment that is no longer relevant * Remove extra tests
thomasneirynck · Dec 18, 2017 · 74c3ddf · 74c3ddf
1 parent f4ed330
commit 74c3ddf
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 7 deletions.
diff --git a/src/ui/public/partials/paginated_selectable_list.html b/src/ui/public/partials/paginated_selectable_list.html
@@ -48,7 +48,10 @@
   </button>
   <ul class="li-striped list-group list-group-menu">
     <li class="list-group-item list-group-menu-item" ng-repeat="hit in page">
-      <a ng-show="userMakeUrl" kbn-href="{{ makeUrl(hit) }}">
+      <a
+        data-test-subj="paginatedListItem-{{accessor(hit)}}"
+        ng-show="userMakeUrl"
+        kbn-href="{{ makeUrl(hit) }}">
         <span>{{ accessor(hit) }}</span>
       </a>
 

diff --git a/test/functional/apps/dashboard/_dashboard.js b/test/functional/apps/dashboard/_dashboard.js
@@ -239,9 +239,7 @@ export default function ({ getService, getPageObjects }) {
       });
     });
 
-
-    // Re-endable once https://github.com/elastic/kibana/issues/15504 is fixed.
-    describe.skip('add new visualization link', () => {
+    describe('add new visualization link', () => {
       it('adds a new visualization', async () => {
         await PageObjects.dashboard.clickEdit();
         await PageObjects.dashboard.clickAddVisualization();

diff --git a/test/functional/apps/dashboard/_dashboard_queries.js b/test/functional/apps/dashboard/_dashboard_queries.js
@@ -36,6 +36,7 @@ export default function ({ getService, getPageObjects }) {
       await PageObjects.header.waitUntilLoadingHasFinished();
 
       await PageObjects.visualize.saveVisualization(PIE_CHART_VIS_NAME);
+      await PageObjects.header.clickToastOK();
 
       await PageObjects.header.clickDashboard();
 

diff --git a/test/functional/apps/dashboard/_dashboard_state.js b/test/functional/apps/dashboard/_dashboard_state.js
@@ -156,6 +156,8 @@ export default function ({ getService, getPageObjects }) {
       await PageObjects.visualize.clickMapZoomIn();
 
       await PageObjects.visualize.saveVisualization('Visualization TileMap');
+      await PageObjects.header.clickToastOK();
+
       await PageObjects.header.clickDashboard();
 
       await testSubjects.moveMouseTo('dashboardPanel');

diff --git a/test/functional/page_objects/dashboard_page.js b/test/functional/page_objects/dashboard_page.js
@@ -31,6 +31,7 @@ export function DashboardPageProvider({ getService, getPageObjects }) {
         'defaultIndex': 'logstash-*'
       });
 
+      await kibanaServer.uiSettings.disableToastAutohide();
       await PageObjects.common.navigateToApp('dashboard');
     }
 
@@ -143,7 +144,8 @@ export function DashboardPageProvider({ getService, getPageObjects }) {
 
     async clickFilterButton() {
       log.debug('Clicking filter button');
-      return await testSubjects.click('querySubmitButton');
+      await testSubjects.click('querySubmitButton');
+      await PageObjects.header.waitUntilLoadingHasFinished();
     }
 
     async clickClone() {

diff --git a/test/functional/page_objects/visualize_page.js b/test/functional/page_objects/visualize_page.js
@@ -282,8 +282,9 @@ export function VisualizePageProvider({ getService, getPageObjects }) {
       await find.clickByCssSelector('button[data-test-subj="toggleEditor"]');
     }
 
-    async clickNewSearch() {
-      await find.clickByCssSelector('.list-group-item a');
+    async clickNewSearch(indexPattern = 'logstash-*') {
+      await testSubjects.click(`paginatedListItem-${indexPattern}`);
+      await PageObjects.header.waitUntilLoadingHasFinished();
     }
 
     async setValue(newValue) {