Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created Fork with Pull Request Fixes #716

Closed
KyleStilkey opened this issue Jul 2, 2024 · 19 comments
Closed

Created Fork with Pull Request Fixes #716

KyleStilkey opened this issue Jul 2, 2024 · 19 comments

Comments

@KyleStilkey
Copy link

It seems like support for this has probably ended sadly, I use this for my Home Assistant as it has some very useful features. I have taken all the pull requests and built a fork with the fixes included. I am no developer but any pull requests put in I will pull into my fork until I hoep @thomasloven decides to fix this integration.

https://github.com/KyleStilkey/hass-browser_mod

If you want to use the forked version, just add this as a custom repository in your HACS, remove the old and install this version. This fork will just include any fixes the community makes in hopes we see an official fix some day.
@KJThaDon
Copy link

KJThaDon commented Jul 5, 2024

It seems like support for this has probably ended sadly, I use this for my Home Assistant as it has some very useful features. I have taken all the pull requests and built a fork with the fixes included. I am no developer but any pull requests put in I will pull into my fork until I hoep @thomasloven decides to fix this integration.

https://github.com/KyleStilkey/hass-browser_mod

If you want to use the forked version, just add this as a custom repository in your HACS, remove the old and install this version. This fork will just include any fixes the community makes in hopes we see an official fix some day.

Thank you, however it seems pop up cards are still broken?

@KyleStilkey
Copy link
Author

Correct until someone fixes it, I've just pulled in the fixes in the PR nothing more. I'm no developer and if someone releases a fix, I'll pull it.

@kvanbiesen
Copy link

kvanbiesen commented Jul 7, 2024 •
edited
Loading

I did a push for a fix for the settings page

its also in my repo also.

Carefull, needs a hard refresh on the cache. (In chrome, press f12, then with the mouse, hold left click on the refresh button and select "empty cache and hard reload". On other browsers no idea, app also wait untill it refreshes cache

//edit, didnt test it for the popup card, but i dont use those so cant really test unless someone has an example code

@KyleStilkey
Copy link
Author

I did a push for a fix for the settings page

its also in my repo also.

Carefull, needs a hard refresh on the cache. (In chrome, press f12, then with the mouse, hold left click on the refresh button and select "empty cache and hard reload". On other browsers no idea, app also wait untill it refreshes cache

//edit, didnt test it for the popup card, but i dont use those so cant really test unless someone has an example code

Appreciate it, I'll pull it here in the morning and do some testing see how it goes, I use the popups so I'll test that out.

@lbouriez
Copy link

Hey @KyleStilkey great idea. How do you install your fork through HACS, adding the repo gives me an error :/ ???

@kvanbiesen
Copy link

kvanbiesen commented Jul 11, 2024 via email

@lbouriez
Copy link

Neither yours or his works, I am geting the same error.
image

@kvanbiesen
Copy link

kvanbiesen commented Jul 11, 2024 via email

@kvanbiesen
Copy link

kvanbiesen commented Jul 11, 2024 via email

@lbouriez
Copy link

Thanks...

@KyleStilkey
Copy link
Author

@kvanbiesen I pushed your PR in my fork, sorry have a kid along the way so this week was very busy for us. Hopefully we see a fix for the popups without needing a work around.

@hmmbob
Copy link
Contributor

hmmbob commented Jul 12, 2024 •
edited
Loading

You might want to have a look at fixes in #725 and #727

@kvanbiesen
Copy link

added to mine. Still looking in the borked pop-ups but man this is a huge thing (expecially cause js is not my forte :D )

@KyleStilkey
Copy link
Author

You might want to have a look at fixes in #725 and #727

Thanks, they've been pushed into my fork.

@LDprg
Copy link

LDprg commented Jul 14, 2024

@KyleStilkey Why did you disable issues? it would be great if they re enabled.

@KyleStilkey
Copy link
Author

@KyleStilkey Why did you disable issues? it would be great if they re enabled.

Because they need to be put here, I only put up fixes in the Pull Request for now, I am hoping that @thomasloven ends up fixing these, I am no dev and putting issues in my fork will not solve anything.

@srLinux
Copy link

srLinux commented Jul 18, 2024

omg, you saved my life... thank you!

@Alfiegerner Alfiegerner mentioned this issue Jul 29, 2024
Closed
4 tasks
@thomasloven
Copy link
Owner

Thanks for your dedication and help!
I've had a bit of family health issues this spring, so a lot of things have had to be put on hold.

I've tested and merged all open PRs but one into release 2.3.1.
That should keep things going for a bit.

@KyleStilkey
Copy link
Author

Thank you for this, much appreciated and hope all is well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@KJThaDon @thomasloven @lbouriez @KyleStilkey @kvanbiesen @hmmbob @LDprg @srLinux