Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix some github actions warnings #1

Closed
wants to merge 4 commits into from

Conversation

thomas-riccardi
Copy link
Owner

@thomas-riccardi thomas-riccardi commented Oct 26, 2022

superseeds argoproj#1973 and argoproj#2251

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@github-actions
Copy link

github-actions bot commented Oct 26, 2022

Go Published Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit bfdb19a.

♻️ This comment has been updated with latest results.

The codecov/codecov-action api didn't change with v3.
Node.js version was updated from 12 to 16, fixing deprecation warning.

See: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/

Signed-off-by: Thomas Riccardi <[email protected]>
The actions/upload-artifact api didn't change with v3.
Node.js version was updated from 12 to 16, fixing deprecation warning.

See: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/

Signed-off-by: Thomas Riccardi <[email protected]>
@github-actions
Copy link

github-actions bot commented Oct 26, 2022

E2E Tests Published Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit bfdb19a.

♻️ This comment has been updated with latest results.

…ifacts from another workflow

Signed-off-by: Thomas Riccardi <[email protected]>
since v2 of EnricoMi/publish-unit-test-result-action:
warning:
Option FILES is deprecated, please use JUNIT_FILES instead!

all files are junit format, and are all named junit.xml

Signed-off-by: Thomas Riccardi <[email protected]>
@thomas-riccardi thomas-riccardi changed the title ci: fix some actions warning, simplify ci: fix some github actions warnings Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant